From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbcDTAHN (ORCPT ); Tue, 19 Apr 2016 20:07:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38642 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948AbcDTAHL (ORCPT ); Tue, 19 Apr 2016 20:07:11 -0400 Date: Tue, 19 Apr 2016 20:07:09 -0400 (EDT) Message-Id: <20160419.200709.1456260686653504927.davem@davemloft.net> To: khlebnikov@yandex-team.ru Cc: netdev@vger.kernel.org, yishaih@mellanox.com, eugenia@mellanox.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx4_en: do batched put_page using atomic_sub From: David Miller In-Reply-To: <146097924572.15144.10837875571142670008.stgit@buzz> References: <146097924572.15144.10837875571142670008.stgit@buzz> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Apr 2016 17:07:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Khlebnikov Date: Mon, 18 Apr 2016 14:34:05 +0300 > This patch fixes couple error paths after allocation failures. > Atomic set of page reference counter is safe only if it is zero, > otherwise set can race with any speculative get_page_unless_zero. > > Signed-off-by: Konstantin Khlebnikov Applied.