From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbcDSW47 (ORCPT ); Tue, 19 Apr 2016 18:56:59 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38953 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751209AbcDSW45 (ORCPT ); Tue, 19 Apr 2016 18:56:57 -0400 Date: Wed, 20 Apr 2016 00:56:55 +0200 From: Alexandre Belloni To: Nishanth Menon Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Lange Subject: Re: [PATCH] rtc: ds1307: Use irq when available for wakeup-source device Message-ID: <20160419225655.GJ29844@piout.net> References: <1461083034-9227-1-git-send-email-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461083034-9227-1-git-send-email-nm@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2016 at 11:23:54 -0500, Nishanth Menon wrote : > With commit 8bc2a40730ec ("rtc: ds1307: add support for the > DT property 'wakeup-source'") we lost the ability for rtc irq > functionality for devices that are actually hooked on a real IRQ > line and have capability to wakeup as well. This is not an expected > behavior. So, instead of just not requesting IRQ, skip the IRQ > requirement only if interrupts are not defined for the device. > > Fixes: 8bc2a40730ec ("rtc: ds1307: add support for the DT property 'wakeup-source'") > Reported-by: Tony Lindgren > Cc: Michael Lange > Cc: Alexandre Belloni > Signed-off-by: Nishanth Menon > --- > > drivers/rtc/rtc-ds1307.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com