From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: torvalds@linux-foundation.org, tglx@linutronix.de, bp@alien8.de,
peterz@infradead.org, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org, mingo@kernel.org,
acme@infradead.org, hpa@zytor.com, a.p.zijlstra@chello.nl
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] perf/core, sched: Don't use clock function pointer to determine clock
Date: Wed, 20 Apr 2016 07:06:16 +0200 [thread overview]
Message-ID: <20160420050616.GF5862@linaro.org> (raw)
In-Reply-To: <tip-f454bfddf6ba557381d8bf5df50eff778602ff23@git.kernel.org>
On Tue, Apr 19, 2016 at 02:34:50AM -0700, tip-bot for Alexander Shishkin wrote:
> Commit-ID: f454bfddf6ba557381d8bf5df50eff778602ff23
> Gitweb: http://git.kernel.org/tip/f454bfddf6ba557381d8bf5df50eff778602ff23
> Author: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> AuthorDate: Thu, 14 Apr 2016 14:59:49 +0300
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 19 Apr 2016 10:55:29 +0200
>
> perf/core, sched: Don't use clock function pointer to determine clock
>
> Now that local_clock() is explicitly inlined in sched.h, taking its
> pointer would uninline it in the compilation unit where it's done,
> making (among other things) comparing pointers to this function
> produce different results in different compilation units.
>
> Case in point, x86 perf core's user page updating function compares
> event's clock against &local_clock to see if it needs to set zero
> time offset related bits in the page.
>
> This patch fixes the latter by looking at the "use_clockid" event
> attribute instead, to determine whether local clock is used. Fixing
> the uninlined local_clock() in perf core is left as an exercise for
> the author of the prior work.
Ouch! Good exercise :)
prev parent reply other threads:[~2016-04-20 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 11:59 [PATCH] perf, x86: " Alexander Shishkin
2016-04-19 9:34 ` [tip:sched/core] perf/core, sched: " tip-bot for Alexander Shishkin
2016-04-20 5:06 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420050616.GF5862@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome