From: Johannes Thumshirn <jthmshirn@suse.de>
To: Andreas Werner <andreas.werner@men.de>
Cc: morbidrsa@gmail.com, linux-kernel@vger.kernel.org, jthumshirn@suse.de
Subject: Re: [PATCH] mcb: Fixed bar number assignment for the gdd
Date: Wed, 20 Apr 2016 10:57:55 +0200 [thread overview]
Message-ID: <20160420085755.GA28402@c203.arch.suse.de> (raw)
In-Reply-To: <20160420063538.GA2684@awelinux>
On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote:
> The bar number is found in reg2 within the gdd. Therefore
> we need to change the assigment from reg1 to reg2 which
> is the correct location.
>
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
> drivers/mcb/mcb-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
> index 0049269..b0155b0 100644
> --- a/drivers/mcb/mcb-parse.c
> +++ b/drivers/mcb/mcb-parse.c
> @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
> mdev->id = GDD_DEV(reg1);
> mdev->rev = GDD_REV(reg1);
> mdev->var = GDD_VAR(reg1);
> - mdev->bar = GDD_BAR(reg1);
> + mdev->bar = GDD_BAR(reg2);
> mdev->group = GDD_GRP(reg2);
> mdev->inst = GDD_INS(reg2);
>
> --
> 2.6.2
>
Applied, thanks.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2016-04-20 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 6:35 Andreas Werner
2016-04-20 8:57 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420085755.GA28402@c203.arch.suse.de \
--to=jthmshirn@suse.de \
--cc=andreas.werner@men.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®