From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Wanpeng Li <kernellwp@gmail.com>, Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org, Wanpeng Li <wanpeng.li@hotmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Steve Muckle <steve.muckle@linaro.org>
Subject: Re: [PATCH] sched/cpufreq: don't trigger cpufreq update w/o real rt/deadline tasks running
Date: Wed, 20 Apr 2016 16:01:17 +0200 [thread overview]
Message-ID: <20160420140117.GZ3448@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <6087716.bi8vDPiZNy@vostro.rjw.lan>
On Wed, Apr 20, 2016 at 02:32:35AM +0200, Rafael J. Wysocki wrote:
> On Monday, April 18, 2016 01:51:24 PM Wanpeng Li wrote:
> > Sometimes update_curr() is called w/o tasks actually running, it is
> > captured by:
> > u64 delta_exec = rq_clock_task(rq) - curr->se.exec_start;
> > We should not trigger cpufreq update in this case for rt/deadline
> > classes, and this patch fix it.
> >
> > Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
>
> The signed-off-by tag should agree with the From: header. One way to achieve
> that is to add an extra From: line at the start of the changelog.
>
> That said, this looks like a good catch that should go into 4.6 to me.
>
> Peter, what do you think?
I'm confused by the Changelog. *what* ?
next prev parent reply other threads:[~2016-04-20 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 5:51 Wanpeng Li
2016-04-20 0:32 ` Rafael J. Wysocki
2016-04-20 0:48 ` Wanpeng Li
2016-04-20 14:01 ` Peter Zijlstra [this message]
2016-04-20 22:24 ` Wanpeng Li
2016-04-20 22:28 ` Rafael J. Wysocki
2016-04-21 1:09 ` Wanpeng Li
2016-04-21 11:11 ` Rafael J. Wysocki
2016-04-21 12:12 ` Wanpeng Li
2016-04-21 12:25 ` Wanpeng Li
2016-04-21 12:33 ` Peter Zijlstra
2016-04-21 13:33 ` Wanpeng Li
2016-04-21 17:07 ` Rafael J. Wysocki
2016-04-21 17:17 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420140117.GZ3448@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernellwp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=steve.muckle@linaro.org \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome