From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: James Hogan <james.hogan@imgtec.com>,
Paolo Bonzini <pbonzini@redhat.com>,
mingo@redhat.com, linux-mips@linux-mips.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, qemu-ppc@nongnu.org,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation
Date: Wed, 20 Apr 2016 19:53:29 +0200 [thread overview]
Message-ID: <20160420195329.23c8982c@bahia.huguette.org> (raw)
In-Reply-To: <20160420172706.GA4044@potion>
On Wed, 20 Apr 2016 19:27:06 +0200
Radim Krčmář <rkrcmar@redhat.com> wrote:
> 2016-04-20 18:09+0100, James Hogan:
> > On Wed, Apr 20, 2016 at 07:02:10PM +0200, Radim Krčmář wrote:
> >> 2016-04-20 17:44+0200, Greg Kurz:
> >> > diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
> >> > index 70ef1a43c114..0278ea146db5 100644
> >> > --- a/arch/mips/kvm/mips.c
> >> > +++ b/arch/mips/kvm/mips.c
> >> > @@ -248,9 +248,14 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, unsigned int id)
> >> > int err, size, offset;
> >> > void *gebase;
> >> > int i;
> >> > + struct kvm_vcpu *vcpu;
> >> >
> >> > - struct kvm_vcpu *vcpu = kzalloc(sizeof(struct kvm_vcpu), GFP_KERNEL);
> >> > + if (id >= KVM_MAX_VCPUS) {
> >> > + err = -EINVAL;
> >> > + goto out;
> >>
> >> 'vcpu' looks undefined at this point, so kfree in 'out:' may bug.
> >
> > Thats out_free_cpu I think?
>
> My bad, it is. Thank you!
>
I kept the goto based construct because it was done this way for kzalloc().
but I agree that 'return ERR_PTR(-EINVAL)' may look more explicit.
Worth a v4 ?
Cheers.
--
Greg
next prev parent reply other threads:[~2016-04-20 17:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 15:44 Greg Kurz
2016-04-20 16:10 ` James Hogan
2016-04-20 16:48 ` Cornelia Huck
2016-04-21 13:24 ` David Hildenbrand
2016-04-20 17:02 ` Radim Krčmář
2016-04-20 17:09 ` James Hogan
2016-04-20 17:27 ` Radim Krčmář
2016-04-20 17:53 ` Greg Kurz [this message]
2016-04-20 18:31 ` Radim Krčmář
2016-04-20 18:29 ` Radim Krčmář
2016-04-21 11:29 ` Greg Kurz
2016-04-21 12:26 ` Cornelia Huck
2016-04-21 13:05 ` Greg Kurz
2016-04-21 13:22 ` David Hildenbrand
2016-04-21 15:29 ` Radim Krčmář
2016-04-21 15:49 ` Greg Kurz
2016-04-21 16:08 ` Radim Krčmář
2016-04-21 17:18 ` Greg Kurz
2016-04-21 17:39 ` Radim Krčmář
2016-04-21 18:08 ` Greg Kurz
2016-04-22 1:40 ` Wanpeng Li
2016-04-22 13:07 ` Radim Krčmář
2016-04-23 22:54 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420195329.23c8982c@bahia.huguette.org \
--to=gkurz@linux.vnet.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-ppc@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®