From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbcDUSbN (ORCPT ); Thu, 21 Apr 2016 14:31:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbcDUSbL (ORCPT ); Thu, 21 Apr 2016 14:31:11 -0400 Date: Thu, 21 Apr 2016 14:31:09 -0400 (EDT) Message-Id: <20160421.143109.221343460795174482.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, mugunthanvnm@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open From: David Miller In-Reply-To: <1461089389-17508-1-git-send-email-grygorii.strashko@ti.com> References: <1461089389-17508-1-git-send-email-grygorii.strashko@ti.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Apr 2016 11:31:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:09:49 +0300 > The cpsw_ndo_open() could try to access CPSW registers before > calling pm_runtime_get_sync(). This will trigger L3 error: > > WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c() > 44000000.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data Access in Supervisor mode during Functional access > > and CPSW will stop functioning. > > Hence, fix it by moving pm_runtime_get_sync() before the first access > to CPSW registers in cpsw_ndo_open(). > > Signed-off-by: Grygorii Strashko Applied, thanks.