From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Add missing render node support
Date: Thu, 21 Apr 2016 09:24:44 +0200 [thread overview]
Message-ID: <20160421072444.GU2510@phenom.ffwll.local> (raw)
In-Reply-To: <1461190849-22877-1-git-send-email-eric@anholt.net>
On Wed, Apr 20, 2016 at 03:20:49PM -0700, Eric Anholt wrote:
> There shouldn't be any other driver support necessary, since none of
> the driver-specific ioctls ever required auth, and none of them deal
> with modesetting.
Indeed, somehow I thought you need to mark them all up explicitly. But
that's only the case for DRM_AUTH ioctls.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Aside: I wonder whether we should go through all the drivers and replace
DRM_AUTH | DRM_RENDER_ALLOW with 0? It looks a bit like drm ioctl flags
are cargo culted ...
-Daniel
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 54f9f52fa004..143dd98aa079 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -81,6 +81,7 @@ static struct drm_driver vc4_drm_driver = {
> DRIVER_ATOMIC |
> DRIVER_GEM |
> DRIVER_HAVE_IRQ |
> + DRIVER_RENDER |
> DRIVER_PRIME),
> .lastclose = vc4_lastclose,
> .irq_handler = vc4_irq,
> --
> 2.8.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-04-21 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 22:20 Eric Anholt
2016-04-21 7:24 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421072444.GU2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®