From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-kernel@vger.kernel.org
Subject: Re: watchdog: deadlock warning with imx2_wdt driver and systemd
Date: Thu, 21 Apr 2016 15:44:45 +0200 [thread overview]
Message-ID: <20160421134444.GA1515@archie.localdomain> (raw)
In-Reply-To: <5718574F.5090809@roeck-us.net>
On Wed, Apr 20, 2016 at 09:30:07PM -0700, Guenter Roeck wrote:
>
> Hi Clemens,
>
> fix is to drop the call to cancel_delayed_work_sync() from watchdog_release().
> Turns out the call is not necessary.
>
> I'll send a proper patch in the next couple of days.
>
> Guenter
>
Hi Guenter,
thank you for finding the cause of the problem! Removing the
cancel_delayed_work_sync call from watchdog_release in watchdog_dev.c
did fix the lockdep warning on all my boards [without having to revert
commit 11d7aba9ce (watchdog: imx2: Convert to use infrastructure
triggered keepalives) first].
Tested-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Cheers,
Clemens
prev parent reply other threads:[~2016-04-21 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 15:41 Clemens Gruber
2016-04-18 0:17 ` Guenter Roeck
2016-04-21 4:30 ` Guenter Roeck
2016-04-21 13:44 ` Clemens Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421134444.GA1515@archie.localdomain \
--to=clemens.gruber@pqgruber.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®