From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbcDUOvy (ORCPT ); Thu, 21 Apr 2016 10:51:54 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:41968 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbcDUOvw (ORCPT ); Thu, 21 Apr 2016 10:51:52 -0400 Date: Thu, 21 Apr 2016 15:50:55 +0100 From: One Thousand Gnomes To: Guenter Roeck Cc: Wim Van Sebroeck , Clemens Gruber , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: core: Fix circular locking dependency Message-ID: <20160421155055.503e6d23@lxorguk.ukuu.org.uk> In-Reply-To: <1461249494-24924-1-git-send-email-linux@roeck-us.net> References: <1461249494-24924-1-git-send-email-linux@roeck-us.net> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Turns out the call to cancel_delayed_work_sync() in watchdog_release() > is not necessary and can be dropped. If the worker is no longer necessary, > the subsequent call to watchdog_update_worker() will cancel it. If it is > already running, it won't do anything, since the worker function checks > if it needs to ping the watchdog or not. Is this actually true. Consider the pathalogical case of the device being closed and the modue unloaded. In that case the close completes, we drop the module count but could still do work on it. Alan