From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbcDUUkG (ORCPT ); Thu, 21 Apr 2016 16:40:06 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33576 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbcDUUkE (ORCPT ); Thu, 21 Apr 2016 16:40:04 -0400 Date: Thu, 21 Apr 2016 22:39:42 +0200 From: Borislav Petkov To: Peter Zijlstra Cc: Thomas Gleixner , Alexander Shishkin , Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Message-ID: <20160421203942.GM28821@pd.tnic> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-3-git-send-email-alexander.shishkin@linux.intel.com> <20160421174813.GA29639@pd.tnic> <20160421191702.GL3430@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160421191702.GL3430@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 09:17:02PM +0200, Peter Zijlstra wrote: > So I agree with Thomas; the risk of not doing this is that we'll > introduce the same MSR again, in another file, under another name. ... only if that MSR is useful in other compilation units. If not, then you're unlikely to need it somewhere else. That's why I meant if it is PT-relevant only, to define it in its header instead. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.