From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbcDUXWS (ORCPT ); Thu, 21 Apr 2016 19:22:18 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48929 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751659AbcDUXWQ (ORCPT ); Thu, 21 Apr 2016 19:22:16 -0400 Date: Fri, 22 Apr 2016 01:22:14 +0200 From: Alexandre Belloni To: Stefan Agner Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: snvs: return error in case enable_irq_wake fails Message-ID: <20160421232214.GE29844@piout.net> References: <1461193797-18015-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461193797-18015-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/04/2016 at 16:09:57 -0700, Stefan Agner wrote : > If enable_irq_wake fails, we should return that error code so that > entering suspend fails. Otherwise we will get a WARNING along with > the hint of a unbalanced wake disable: > Unbalanced IRQ 37 wake disable > > Signed-off-by: Stefan Agner > --- > drivers/rtc/rtc-snvs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com