From: Andrew Morton <akpm@linux-foundation.org>
To: Huang Shijie <shijie.huang@arm.com>
Cc: <pmladek@suse.com>, <steve.capper@arm.com>,
<linux-kernel@vger.kernel.org>, <masami.hiramatsu.pt@hitachi.com>,
<nd@arm.com>
Subject: Re: [PATCH] kprobes: add the "tls" argument for j_do_fork
Date: Fri, 22 Apr 2016 13:58:12 -0700 [thread overview]
Message-ID: <20160422135812.657b9c02f65a94ac1c34cc45@linux-foundation.org> (raw)
In-Reply-To: <1460625400-22319-1-git-send-email-shijie.huang@arm.com>
On Thu, 14 Apr 2016 17:16:40 +0800 Huang Shijie <shijie.huang@arm.com> wrote:
> The patch "3033f14a clone: support passing tls argument via C rather ..."
> added the tls argument for _do_fork(). The patch adds the "tls" argument
> for j_do_fork to make it match _do_fork().
>
> ...
>
> --- a/samples/kprobes/jprobe_example.c
> +++ b/samples/kprobes/jprobe_example.c
> @@ -25,7 +25,7 @@
> /* Proxy routine having the same arguments as actual _do_fork() routine */
> static long j_do_fork(unsigned long clone_flags, unsigned long stack_start,
> unsigned long stack_size, int __user *parent_tidptr,
> - int __user *child_tidptr)
> + int __user *child_tidptr, unsigned long tls)
> {
> pr_info("jprobe: clone_flags = 0x%lx, stack_start = 0x%lx "
> "stack_size = 0x%lx\n", clone_flags, stack_start, stack_size);
The changelog failed to tell us what are the runtime effects of this
bug. Please always include this info so that others can decide
which kernel version(s) need fixing.
Thanks.
next prev parent reply other threads:[~2016-04-22 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 9:16 Huang Shijie
2016-04-18 13:45 ` Petr Mladek
2016-04-22 20:58 ` Andrew Morton [this message]
2016-04-25 8:39 ` Petr Mladek
2016-04-25 9:18 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422135812.657b9c02f65a94ac1c34cc45@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=nd@arm.com \
--cc=pmladek@suse.com \
--cc=shijie.huang@arm.com \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®