mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] printk: Add kernel parameter to disable writes to /dev/kmsg
Date: Mon, 25 Apr 2016 14:40:56 -0400	[thread overview]
Message-ID: <20160425144056.288eea62@gandalf.local.home> (raw)
In-Reply-To: <20160425183249.GK28454@pd.tnic>

On Mon, 25 Apr 2016 20:32:50 +0200
Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Apr 25, 2016 at 01:08:53PM -0400, Steven Rostedt wrote:
> > [ Sorry for the resend, I forgot to add "[PATCH]" to the subject, which
> >   may make this fail filters. ]
> > 
> > Over the weekend my server was acting funny. The display wasn't working
> > well, and I assumed that a driver was going bad. I went to look at the
> > kernel dmesg, but the buffer only had the following over and over:  
> 
> ...
> 
> > +	disable_devkmsg_write
> > +			Disable writing to /dev/kmsg. This prevents user space
> > +			tools from writing into the kernel printk buffers.
> > +			When set, opening /dev/kmsg for write mode will return
> > +			-EPERM.  
> 
> I like the general idea.
> 
> Perhaps can call that param "printk.disable_devkmsg" or so with the
> proper namespace and in light of printk.always_kmsg_dump=...
> 

I agree. And Uwe Kleine-König suggested to make it read_mostly.

I'll send a v2.

-- Steve

  reply	other threads:[~2016-04-25 18:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 17:06 Steven Rostedt
2016-04-25 17:08 ` [PATCH] " Steven Rostedt
2016-04-25 18:32   ` Borislav Petkov
2016-04-25 18:40     ` Steven Rostedt [this message]
2016-04-25 18:50 ` Peter Zijlstra
2016-04-26 18:44 ` Pavel Machek
2016-04-26 19:47   ` Steven Rostedt
2016-04-27 11:25     ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425144056.288eea62@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®