From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932918AbcDYRaj (ORCPT ); Mon, 25 Apr 2016 13:30:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41856 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754707AbcDYRai (ORCPT ); Mon, 25 Apr 2016 13:30:38 -0400 Date: Mon, 25 Apr 2016 18:30:24 +0100 From: Mark Brown To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , MyungJoo Ham , Chanwoo Choi , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160425173024.GO3217@sirena.org.uk> References: <1461571496-9600-1-git-send-email-baolu.lu@linux.intel.com> <1461571496-9600-5-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZYwTRRUThkGj9JQ7" Content-Disposition: inline In-Reply-To: <1461571496-9600-5-git-send-email-baolu.lu@linux.intel.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZYwTRRUThkGj9JQ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 25, 2016 at 04:04:50PM +0800, Lu Baolu wrote: > + ret = device_property_read_string(dev, "gpio-name", &gpio_name); > + if (!ret) { > + gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS); > + if (!IS_ERR(gpiod)) { This doesn't look like it's a standard ACPI binding for GPIOs, why are we using a property to get the GPIO noame? --ZYwTRRUThkGj9JQ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXHlQuAAoJECTWi3JdVIfQJXYH/jBYC0G0+bjZFR/cxyvS5AY3 QHH8lMricOI10floFM+W2dP7Dim3azFlEuvVTkmnWl8plbZJEG+XB5X2Dr4BCYsR tA3En5xVDFNiMaxkacNXMMqaTUY8onvbhdOVuvjwnjnunYHKzfiXthUeUlvk4QXv 1vMnR6yDnhd7E925+hETfy5i+81wEY2qHMJ5YGRNuh7clpdgaSbFpx6wgS1LzNSe Ev/kfp/muXeNJ8cxu33w0Eg7haz0Hb5dREaHjdjbIL/jz/M5e7hvagQSBBmUlrYj YqLzk6Ogv9SpPj8FZtBIHsQlCavFEuREwrEHHuRj9wL/JoZq80pxfr8KhD5zqNk= =2zUu -----END PGP SIGNATURE----- --ZYwTRRUThkGj9JQ7--