From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: <jim_baxter@mentor.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Looijmans <mike.looijmans@topic.nl>,
Robert Baldyga <r.baldyga@samsung.com>,
Mark Craske <Mark_Craske@mentor.com>
Subject: Re: [PATCH v1 1/1] usb: gadget: NCM: NULL pointer dereference in eth_start_xmit
Date: Mon, 25 Apr 2016 17:51:57 +0100 [thread overview]
Message-ID: <20160425175157.012ec034@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1461597903-17788-1-git-send-email-jim_baxter@mentor.com>
On Mon, 25 Apr 2016 16:25:03 +0100
<jim_baxter@mentor.com> wrote:
> From: Jim Baxter <jim_baxter@mentor.com>
>
> "Unable to handle kernel NULL pointer dereference at virtual address
> 00000078" is reported with "PC is at eth_start_xmit+0x19c/0x378 [u_ether]"
>
> The failure scenario is seen when closing the NCM connection while the
> TCP/IPv6 stack is still trying to transmit over NCM.
>
> Defensive code is missing from commit
> 6d3865f9d41f15ddbcecaa6722871fc0db21d7ab
> "usb: gadget: NCM: Add transmit multi-frame."
This looks inadequate. Surely you also need to hold dev->lock ?
Also it'll also crash at the no zlp test with the same problem.
Alan
prev parent reply other threads:[~2016-04-25 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 15:25 jim_baxter
2016-04-25 16:51 ` One Thousand Gnomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425175157.012ec034@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=Mark_Craske@mentor.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jim_baxter@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®