From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965117AbcDYVdX (ORCPT ); Mon, 25 Apr 2016 17:33:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:41456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964906AbcDYVdW (ORCPT ); Mon, 25 Apr 2016 17:33:22 -0400 Date: Tue, 26 Apr 2016 06:33:17 +0900 From: Masami Hiramatsu To: Colin King Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: replace assignment with comparison on assert check Message-Id: <20160426063317.6b2f604d93c6f3d1462dacdf@kernel.org> In-Reply-To: <1461419154-16918-1-git-send-email-colin.king@canonical.com> References: <1461419154-16918-1-git-send-email-colin.king@canonical.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Apr 2016 14:45:54 +0100 Colin King wrote: > From: Colin Ian King > > The current assert check is checking an assignment, which will always > be true. Instead, the assert should be checking if scale is equal > to 0.122 > Looks good to me. Reviewed-by: Masami Hiramatsu > Signed-off-by: Colin Ian King > --- > tools/perf/tests/event_update.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c > index 012eab5..63ecf21 100644 > --- a/tools/perf/tests/event_update.c > +++ b/tools/perf/tests/event_update.c > @@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused, > > TEST_ASSERT_VAL("wrong id", ev->id == 123); > TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE); > - TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123); > + TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123); > return 0; > } > > -- > 2.7.4 > -- Masami Hiramatsu