From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbcDZTvi (ORCPT ); Tue, 26 Apr 2016 15:51:38 -0400 Received: from smtprelay0113.hostedemail.com ([216.40.44.113]:49811 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752014AbcDZTvg (ORCPT ); Tue, 26 Apr 2016 15:51:36 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2908:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6261:7875:7903:10004:10400:10848:10967:11232:11658:11914:12043:12296:12517:12519:12555:12663:12740:13069:13311:13357:13439:14181:14659:14721:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: guide36_2abfe68df3d1a X-Filterd-Recvd-Size: 2396 Date: Tue, 26 Apr 2016 15:51:32 -0400 From: Steven Rostedt To: Benjamin Poirier Cc: Michal Marek , joeyli , "Yann E . MORIN " , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] localmodconfig: Fix whitespace repeat count after "tristate" Message-ID: <20160426155132.3cdf9adf@gandalf.local.home> In-Reply-To: <1461696998-3953-1-git-send-email-bpoirier@suse.com> References: <20160426185421.GB2979@f1.synalogic.ca> <1461696998-3953-1-git-send-email-bpoirier@suse.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Apr 2016 11:56:38 -0700 Benjamin Poirier wrote: > Also recognize standalone "prompt". > > Before this patch we incorrectly identified some symbols as not having a > prompt and potentially needing to be selected by something else. > > Note that this patch could theoretically change the resulting .config, > causing it to have fewer symbols turned on. However, given the current set > of Kconfig files, this situation does not occur because the symbols newly > added to %prompts are absent from %selects. > > Signed-off-by: Benjamin Poirier > --- > scripts/kconfig/streamline_config.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl > index 95a6f2b..b8c7b29 100755 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -237,7 +237,7 @@ sub read_kconfig { > } > > # configs without prompts must be selected > - } elsif ($state ne "NONE" && /^\s*tristate\s\S/) { > + } elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) { I prefer not to have the "prompt" here. I'm only interested in module configs. But the \s to \s+ is a real fix. Can you resend? -- Steve > # note if the config has a prompt > $prompts{$config} = 1; >