From: Rich Felker <dalias@libc.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Darren Hart <dvhart@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Greg Ungerer <gerg@uclinux.org>, Steven Miao <realmz6@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] futex: fix shared futex operations on nommu
Date: Tue, 26 Apr 2016 11:53:44 -0400 [thread overview]
Message-ID: <20160426155344.GK21636@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160426095552.GB8295@linutronix.de>
On Tue, Apr 26, 2016 at 11:55:52AM +0200, Sebastian Andrzej Siewior wrote:
> * Rich Felker | 2016-04-25 21:03:03 [-0400]:
>
> >The shared get_futex_key code does not work on nommu, but is not
> >needed anyway because it's impossible for a given backing to have
> >multiple distinct virtual addresses on nommu. Simply disable these
> >code paths by refraining from setting FLAG_SHARED when CONFIG_MMU is
> >not enabled.
>
> by disabling it you are not fixing it.
> Why isn't it working? Why does it pop up now and not earlier?
The whole shared futex logic is meaningless for nommu. Perhaps I
should have written a better message, though.
With MMU, shared futex keys need to identify the physical backing for
a memory address because it may be mapped at different addresses in
different processes (or even multiple times in the same process).
Without MMU this cannot happen. You only have physical addresses. So
the "private futex" behavior of using the virtual address as the key
is always correct (for both shared and private cases) on nommu
systems.
Rich
next prev parent reply other threads:[~2016-04-26 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 1:03 Rich Felker
2016-04-26 9:55 ` Sebastian Andrzej Siewior
2016-04-26 15:53 ` Rich Felker [this message]
2016-04-26 16:11 ` Sebastian Andrzej Siewior
2016-04-26 16:27 ` Rich Felker
2016-04-26 22:27 ` Andrew Morton
2016-04-26 22:31 ` Rich Felker
2016-04-27 13:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426155344.GK21636@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dvhart@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=realmz6@gmail.com \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®