From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbcDZUQ1 (ORCPT ); Tue, 26 Apr 2016 16:16:27 -0400 Received: from smtprelay0125.hostedemail.com ([216.40.44.125]:57091 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751999AbcDZUQZ (ORCPT ); Tue, 26 Apr 2016 16:16:25 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3355:3622:3865:3866:3867:3868:3870:3874:4250:4321:5007:6261:7875:7903:7974:8957:9040:9163:10004:10400:10848:10967:11026:11232:11658:11914:12043:12291:12296:12438:12517:12519:12555:12683:12740:13439:14181:14659:14721:21080:21365,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: angle02_71dd24e3ed81f X-Filterd-Recvd-Size: 4724 Date: Tue, 26 Apr 2016 16:16:21 -0400 From: Steven Rostedt To: "Paul E. McKenney" Cc: Tony Lindgren , linux-kernel@vger.kernel.org, mingo@kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426161621.34872b7f@gandalf.local.home> In-Reply-To: <20160426200613.GO3715@linux.vnet.ibm.com> References: <1461617335-22372-1-git-send-email-paulmck@linux.vnet.ibm.com> <20160426150031.GP5995@atomide.com> <20160426175214.GJ3715@linux.vnet.ibm.com> <20160426182939.GO5995@atomide.com> <20160426190755.GK3715@linux.vnet.ibm.com> <20160426193949.GP5995@atomide.com> <20160426154414.7bb33de4@gandalf.local.home> <20160426195158.GR5995@atomide.com> <20160426200613.GO3715@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Apr 2016 13:06:13 -0700 "Paul E. McKenney" wrote: > On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote: > > * Steven Rostedt [160426 12:45]: > > > *Whack* *Whack* *Whack*!!! > > > > > > Signed-off-by: Steven Rostedt > > > --- > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > index fb74dc1f7520..4fa43c02d682 100644 > > > --- a/drivers/clk/clk.c > > > +++ b/drivers/clk/clk.c > > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > > > if (--core->enable_count > 0) > > > return; > > > > > > - trace_clk_disable(core); > > > + trace_clk_disable_rcuidle(core); > > > > > > if (core->ops->disable) > > > core->ops->disable(core->hw); > > > > > > - trace_clk_disable_complete(core); > > > + trace_clk_disable_complete_rcuidle(core); > > > > > > clk_core_disable(core->parent); > > > } > > > > Now the mole shows up here! > > And the patch shows up here! > > Thanx, Paul > > ------------------------------------------------------------------------ > > commit d824fb6beb6e23ade51806e11a882528dc15ae98 > Author: Paul E. McKenney > Date: Tue Apr 26 13:03:51 2016 -0700 > > arm: Whack another event-trace-from-idle mole > > This commit appends a few _rcuidle suffixes to fix the following > RCU-used-from-idle bug: > > > =============================== > > [ INFO: suspicious RCU usage. ] > > 4.6.0-rc5-next-20160426+ #1116 Not tainted > > ------------------------------- > > include/trace/events/rpm.h:95 suspicious rcu_dereference_check() usage! > > > > other info that might help us debug this: > > > > > > RCU used illegally from idle CPU! > > rcu_scheduler_active = 1, debug_locks = 0 > > RCU used illegally from extended quiescent state! > > 1 lock held by swapper/0/0: > > #0: (&(&dev->power.lock)->rlock){-.-...}, at: [] __rpm_callback+0x58/0x60 > > > > stack backtrace: > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1116 > > Hardware name: Generic OMAP36xx (Flattened Device Tree) > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0xb0/0xe4) > > [] (dump_stack) from [] (rpm_suspend+0x580/0x768) > > [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) > > [] (__pm_runtime_suspend) from [] (omap2_gpio_prepare_for_idle+0x5c/0x70) > > [] (omap2_gpio_prepare_for_idle) from [] (omap_sram_idle+0x140/0x244) > > [] (omap_sram_idle) from [] (omap3_enter_idle_bm+0xfc/0x1ec) > > [] (omap3_enter_idle_bm) from [] (cpuidle_enter_state+0x80/0x3d4) > > [] (cpuidle_enter_state) from [] (cpu_startup_entry+0x198/0x3a0) > > [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8) > > [] (start_kernel) from [<8000807c>] (0x8000807c) > > In the immortal words of Steven Rostedt, "*Whack* *Whack* *Whack*!!!" WhACKED-by: Steven Rostedt -- Steve