From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753132AbcD0QWs (ORCPT ); Wed, 27 Apr 2016 12:22:48 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50716 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbcD0QWr (ORCPT ); Wed, 27 Apr 2016 12:22:47 -0400 Date: Wed, 27 Apr 2016 12:22:42 -0400 (EDT) Message-Id: <20160427.122242.1614940676503935894.davem@davemloft.net> To: bjorn.andersson@linaro.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, courtney.cavin@sonymobile.com, bjorn.andersson@sonymobile.com Subject: Re: [PATCH v2] net: Add Qualcomm IPC router From: David Miller In-Reply-To: <1461736085-24862-1-git-send-email-bjorn.andersson@linaro.org> References: <1461736085-24862-1-git-send-email-bjorn.andersson@linaro.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Apr 2016 09:22:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Date: Tue, 26 Apr 2016 22:48:05 -0700 > + rc = qcom_smd_send(qdev->channel, skb->data, skb->len); I truly dislike adding networking protocols that depend upon some piece of infrastructure that only some platforms can enable, it's even worse when that set of platforms doesn't intersect with x86-64. When you do things like this, it's quite hard to make protocol wide changes to APIs because build testing becomes an issue. This code can now only be build tested on ARCH_QCOM architectures, and that's a serious negative downside.