From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbcD0MeM (ORCPT ); Wed, 27 Apr 2016 08:34:12 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48692 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbcD0MeI (ORCPT ); Wed, 27 Apr 2016 08:34:08 -0400 Date: Wed, 27 Apr 2016 13:33:49 +0100 From: Mark Brown To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , MyungJoo Ham , Chanwoo Choi , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160427123349.GL3217@sirena.org.uk> References: <1461571496-9600-1-git-send-email-baolu.lu@linux.intel.com> <1461571496-9600-5-git-send-email-baolu.lu@linux.intel.com> <20160425173024.GO3217@sirena.org.uk> <571ED178.4090700@linux.intel.com> <20160426102314.GS3217@sirena.org.uk> <57201BC2.5040409@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ghcfmjchA5OWYfuO" Content-Disposition: inline In-Reply-To: <57201BC2.5040409@linux.intel.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ghcfmjchA5OWYfuO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote: > Please refer to Documentation/acpi/gpio-properties.txt. That's not visibly what your driver is doing, that is also recommending using a static name which is what I'm asking for. > > Why does the device care?It's requesting the GPIO in > > its own context and it's only requesting one GPIO, with DT we're just > > always calling the GPIO "gpio" which works fine. > This driver is not bound to an ACPI device node directly. It's a child > of a mfd device, which is corresponding to a real ACPI device node. If it's the child of a MFD it's got an ACPI device, the ACPI device is the parent. It should use the parent device or the parent should map the GPIO through to the child as many other MFDs do, the whole concept of a MFD is a Linux internal implementation detail. --ghcfmjchA5OWYfuO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXILGrAAoJECTWi3JdVIfQy+oH/RQVg+d5kmA5eWZ5+9LEdefn nyzT7RjXVsehK98HovjEHDO2VRsnGiWTeYCnTznnxA37HH6Dvhfp9TbkCvISmwxQ ec8Kmek/FWvWuxepSHR4i21qzbDYu+04jclO/oDbBjv9KeIUN4ci8z/LmZSpVZPQ IeUtWJxgD75aFuWehh0APj89m520DsNGbMSwe9+nv/mMjrTiFsNUgZivQgAXrlQf WKELwjncmo+o6w08TeK0zgJH5pkrZ2KD+DslvIf0+ID0FEs5f51T2xsZ8jQMcXsd TjuhGJfEArN63Fn1D0vCUFdYDtCzvODU43wgLSjocGr4EfWghLcUbeIBAnTJITg= =Oulw -----END PGP SIGNATURE----- --ghcfmjchA5OWYfuO--