From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbcD0VED (ORCPT ); Wed, 27 Apr 2016 17:04:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720AbcD0VEB (ORCPT ); Wed, 27 Apr 2016 17:04:01 -0400 Date: Wed, 27 Apr 2016 14:03:59 -0700 From: Andrew Morton To: "Ming Li" Cc: "Michal Hocko" , "Kirill A. Shutemov" , "David Rientjes" , "Vlastimil Babka" , "Tejun Heo" , "linux-mm" , "linux-kernel" Subject: Re: [PATCH] mm: put activate_page_pvecs and others pagevec together Message-Id: <20160427140359.a5003280ef5c6bda149ee141@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Apr 2016 09:36:46 +0800 "Ming Li" wrote: > hi, i`m sorry, I made some mistakes in last email. I have been studying mm and learn age_activate_anon(), at the very beginning I felt confuse when I saw activate_page_pvecs, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand. Welcome to kernel development ;) Your email client is mangling the patches in several ways. Please sort that out for next time - mail yourself a patch, check that it applies. The changelog text wasn't very conventional. I rewrote it to : Put the activate_page_pvecs definition next to those of the other : pagevecs, for clarity. and I changed the title to Subject: mm/swap.c: put activate_page_pvecs and other pagevecs together because "mm" is a big place!