From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbcD0V1v (ORCPT ); Wed, 27 Apr 2016 17:27:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50421 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbcD0V1u (ORCPT ); Wed, 27 Apr 2016 17:27:50 -0400 Date: Wed, 27 Apr 2016 14:27:49 -0700 From: Andrew Morton To: Kent Overstreet Cc: Al Viro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: Real pagecache iterators Message-Id: <20160427142749.5b77d723a0b97164f04a91f3@linux-foundation.org> In-Reply-To: <1459478291-29982-2-git-send-email-kent.overstreet@gmail.com> References: <20160401023510.GA28762@kmo-pixel> <1459478291-29982-1-git-send-email-kent.overstreet@gmail.com> <1459478291-29982-2-git-send-email-kent.overstreet@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Mar 2016 18:38:11 -0800 Kent Overstreet wrote: > Introduce for_each_pagecache_page() and related macros, with the goal of > replacing most/all uses of pagevec_lookup(). > > For the most part this shouldn't be a functional change. The one functional > difference with the new macros is that they now take an @end parameter, so we're > able to avoid grabbing pages in __find_get_pages() that we'll never use. > > This patch only does some of the conversions, the ones I was able to easily test > myself - the conversions are mechanical but tricky enough they generally warrent > testing. > > Signed-off-by: Kent Overstreet > Cc: Andrew Morton > Cc: Al Viro > --- > fs/ext4/inode.c | 261 ++++++++++++++++++++---------------------------- > include/linux/pagevec.h | 67 ++++++++++++- > mm/filemap.c | 76 +++++++++----- > mm/page-writeback.c | 148 +++++++++++---------------- > mm/swap.c | 33 +----- > mm/truncate.c | 259 +++++++++++++++++------------------------------ > 6 files changed, 380 insertions(+), 464 deletions(-) hm, it's a lot of churn in sensitive areas for an 80 line saving. What do others think?