From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcD0Oh0 (ORCPT ); Wed, 27 Apr 2016 10:37:26 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49708 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbcD0OhX (ORCPT ); Wed, 27 Apr 2016 10:37:23 -0400 Date: Wed, 27 Apr 2016 15:37:11 +0100 From: Mark Brown To: Hans de Goede Cc: Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , Linux Kernel Mailing List Message-ID: <20160427143711.GT3217@sirena.org.uk> References: <1461765825-15915-1-git-send-email-hdegoede@redhat.com> <1461765825-15915-2-git-send-email-hdegoede@redhat.com> <20160427142432.GR3217@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Za63U8UmC/xhCFi7" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Za63U8UmC/xhCFi7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2016 at 04:31:02PM +0200, Hans de Goede wrote: > On 27-04-16 16:24, Mark Brown wrote: > >The regulator API should not touch any regulators that it doesn't have > >permission to change the state for. All other regulators are strictly > >read only. > How do we give permission to change state ? Is omitting the dts node, > and thus not returning a node / constrains from regulator_of_get_init_data > enough for the regulator API to not have permission ? Yes, omit the DT node or mark it always on at the minute. > Is there any way to see this in sysfs ? Not off the top of my head, but it's in debugfs. > >If the regulator can't be changed why is it in the DT in the first > >place? > The regulator is part of the pmic and the axp20x regulator driver > registers all regulators on the pmic when the pmic-s mfd instantiated > regulators-platform-device gets probed. That's the driver, that's not the DT. Drivers should always register all the regulators in the device they're for. --Za63U8UmC/xhCFi7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXIM6XAAoJECTWi3JdVIfQFxYH+gP4AFfg1l6TV4HyY3L47p/W rYphoBCUrMG2QNlqwEcVM4oOMxed/O+h603WzYkm6HlzY1yLL9hvF56QnMhs+7P4 X9mhmZzmMsZHk7ht8Ymfs2CFQzqUFhB6XIGyenehS6cPtz4b/ty4vJIOcVVYKYyb sR+HWDzwiLkmwX/AH2yk4EE2CF88kS5NRo+Xyj2tekm4PRhisk7gXQI08N2iztWz Blq80cxBc+kVFomqvXJxh/F5xcal94FuOM3jubow28L8FH2p/yzsNVwok7SbO8jx trGwi8Fm6nlUSZHyD+Bo0O0nQ6VHKwGADnHNVQGNzY3I9F1by0nCO8MgakkcsrU= =wWkd -----END PGP SIGNATURE----- --Za63U8UmC/xhCFi7--