From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbcD0PMa (ORCPT ); Wed, 27 Apr 2016 11:12:30 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49878 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbcD0PM3 (ORCPT ); Wed, 27 Apr 2016 11:12:29 -0400 Date: Wed, 27 Apr 2016 16:12:19 +0100 From: Mark Brown To: Hans de Goede Cc: Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , Linux Kernel Mailing List Message-ID: <20160427151219.GV3217@sirena.org.uk> References: <1461765568-15828-1-git-send-email-hdegoede@redhat.com> <1461765568-15828-4-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hXYrTO9VFOdlBg/+" Content-Disposition: inline In-Reply-To: <1461765568-15828-4-git-send-email-hdegoede@redhat.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hXYrTO9VFOdlBg/+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2016 at 03:59:28PM +0200, Hans de Goede wrote: > The maximum supported voltage for ldo_io# is 3.3V, but on cold > boot the selector comes up at 0x1f, which maps to 3.8V. Why not just implement that? We know what it does and it preserves the expected behaviour where we don't touch the regualtor unless explicitly told it's OK. We'll only ever try to set that value if the machine explicitly gives permission for it. --hXYrTO9VFOdlBg/+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXINbOAAoJECTWi3JdVIfQ8zEH/igT729dFaZs/Zt1eB3WiO0x LCUBf/2w1rncE68TvSBF6oz8xitx0jv3YUYeFZOJFY3iQXZmcYWdDcyRL9Tkzks+ DmW6DEZnYocC/8jXPyCrbUwP5UCo1H3zcuW0aMI05B70sDxiYKDqXYehidlfbjD4 Q0+J2iTlLwPVIg30J14cTHrOqDSzk6HSMIBjetsKsnG7grEFw3zvusrXmn+c66wz VkiWDUUD0vhH/FzqNJzTt0ROt/6wc8fWk+OI6Jh3cjpXXrQNi+/jxbF3NG22I68j Rijq46e4aKj2/oCwN4BDD0YfA2iZx61eFK1ojnCY/bWsYSL+ltKUbC5cP0PtufE= =U/tX -----END PGP SIGNATURE----- --hXYrTO9VFOdlBg/+--