From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753647AbcD0Pse (ORCPT ); Wed, 27 Apr 2016 11:48:34 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50000 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbcD0Psc (ORCPT ); Wed, 27 Apr 2016 11:48:32 -0400 Date: Wed, 27 Apr 2016 16:48:19 +0100 From: Mark Brown To: Hans de Goede Cc: Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , Linux Kernel Mailing List Message-ID: <20160427154819.GY3217@sirena.org.uk> References: <1461765568-15828-1-git-send-email-hdegoede@redhat.com> <1461765568-15828-4-git-send-email-hdegoede@redhat.com> <20160427151219.GV3217@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HPDgNDXpOr/nqd+F" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HPDgNDXpOr/nqd+F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2016 at 05:35:31PM +0200, Hans de Goede wrote: > On 27-04-16 17:12, Mark Brown wrote: > >Why not just implement that? > Given the formula in the datasheet to calculate the ldo_io > regulator voltage 0x1f maps to 3.8V, but according to the > datasheet the maximum voltage supported is 3.3V, iow the > power-on-reset value of this register is out of spec > according to the datasheet. Well, I guess someone can just measure what happens? > >We know what it does and it preserves the > >expected behaviour where we don't touch the regualtor unless explicitly > >told it's OK. We'll only ever try to set that value if the machine > >explicitly gives permission for it. > The problem is that if we do not fix the out of spec > register value then _regulator_get_voltage returns > -EINVAL because the register value exceeds n_voltages This will no longer be the case when the driver understands what the startup value means. --HPDgNDXpOr/nqd+F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXIN8tAAoJECTWi3JdVIfQjjAH/2NDU41afADsAuNpbG4vCxW1 1DyjAvS5vG6NLMaeqpXm4WWqPx/LL6LmAfV3x75ePksH7W/3aNlWfyPB7WXWN9xd CcNeWSe0RK7p0Y64qX7T5aaTHTxfYjM7D3/gWd6sIwukZPuu7dByS2ahJnPKVCaW +WHiDE70t356dsgRFpyV2NThjPQQGjpdRUx1j9F6NGWikgXNIpiYwEZ2GM7o7xRI bpmO9aJk7fFAUXb0PXM2bLJ2uOSdQZFO1TwJVVIUjzFrbj6O4sRcnGNuMeYNsDHw AupDdT76xFkRTHSluhNgJ6YB/VFFSezF+SJJoxgDUgYP2aq3CA7UpJ6pV8YgbYI= =FvYf -----END PGP SIGNATURE----- --HPDgNDXpOr/nqd+F--