From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752972AbcD1CQi (ORCPT ); Wed, 27 Apr 2016 22:16:38 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35761 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbcD1CQg (ORCPT ); Wed, 27 Apr 2016 22:16:36 -0400 Date: Thu, 28 Apr 2016 07:46:31 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List , Chen Yu Subject: Re: [PATCH] cpufreq: governor: Change confusing struct field and variable names Message-ID: <20160428021631.GU4225@vireshk-i7> References: <2024653.a0XKPA0FXA@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024653.a0XKPA0FXA@vostro.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-04-16, 01:19, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The name of the prev_cpu_wall field in struct cpu_dbs_info is > confusing, because it doesn't represent wall time, but the previous > update time as returned by get_cpu_idle_time() (that may be the > current value of jiffies_64 in some cases, for example). > > Moreover, the names of some related variables in dbs_update() take > that confusion further. > > Rename all of those things to make their names reflect the purpose > more accurately. While at it, drop unnecessary parens from one of > the updated expressions. > > No functional changes. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq_governor.c | 22 +++++++++++----------- > drivers/cpufreq/cpufreq_governor.h | 2 +- > 2 files changed, 12 insertions(+), 12 deletions(-) Acked-by: Viresh Kumar -- viresh