From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752363AbcD1LmI (ORCPT ); Thu, 28 Apr 2016 07:42:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53888 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbcD1LmG (ORCPT ); Thu, 28 Apr 2016 07:42:06 -0400 Date: Thu, 28 Apr 2016 12:41:50 +0100 From: Mark Brown To: Takashi Iwai Cc: Peter Rosin , alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , linux-kernel@vger.kernel.org Message-ID: <20160428114150.GM3217@sirena.org.uk> References: <1461746959-11443-1-git-send-email-peda@axentia.se> <20160427161504.GZ3217@sirena.org.uk> <122ca84a-230e-654e-425f-3adb0ca00ec7@axentia.se> <20160428103822.GJ3217@sirena.org.uk> <20160428111001.GK3217@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fwe/mf09/KM5EodX" Content-Disposition: inline In-Reply-To: X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: pcm: allow changing the playback/capture rates for symmetric links X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fwe/mf09/KM5EodX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 28, 2016 at 01:26:49PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > We've had the code for years without anyone reporting issues so... the > > idiomatic ALSA thing is to set everything in one call which helps a lot. > Yes, most of such problems come from the inconsistent hw constraints, > and one-shot configuration helps indeed. But, in this case, it > appears more like an overlooked case to me. If there's a useful report with the ALSA API then let's look into that - if people can only see this with the OSS API and can't articulate an actual ALSA API level problem then I'm struggling to care. Drivers that do parameter validation tend to fail with OSS anyway as it tries to set partially configured hw_params with invalid values in them and it's not clear to me that this isn't the same thing happening again. > BTW, this reminds me of another question: don't we have a dummy ASoC > driver like snd-dummy? It would be convenient for a casual API > testing. No, someone would need to write a series of dummy drivers that exercised the various API features (almost all of which are kernel internal) and then instantiated them but nobody stepped up and did that yet. --fwe/mf09/KM5EodX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXIfb8AAoJECTWi3JdVIfQFVcH/1jkmlZ5iINv3nnTkWJzT/a3 Y6Lnhgo6aKyi7a48Qh6mrd6Bd2qMXy8gMQr36r9Inp9vZK2nSO/aEFGeDtKqjW1T 9gnRSgNewBRe824aXDanCoI3GhfPSiP/aZvcq6LeiKiFhbshfcfHcTSeMKdmJyqW QYcZwKNsiTDWP8y2Tl6ngf+tOS9AuEEO62WwAIm2tegTRPjn4TS0G/PXM3+SzNnM uPvMDs5/2rlevFWlJAID8jjPYWVGVBDAa3d7hvd4CfM7kzQEJe4M1w86oAIKw2kz lA1IZtML8Nj+X+KFO7XZK9hHBBZBZsy1RueK8ZzstZQHjs8BUagW1WIUtFE1CsI= =I/EW -----END PGP SIGNATURE----- --fwe/mf09/KM5EodX--