mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
	Baoquan He <bhe@redhat.com>, Borislav Petkov <bp@suse.de>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"H.J. Lu" <hjl.tools@gmail.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andy Lutomirski <luto@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/boot: Rename overlapping memcpy() to memmove()
Date: Thu, 28 Apr 2016 17:47:31 +0100	[thread overview]
Message-ID: <20160428174731.042b7394@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <CAGXu5jJLEi2pkdMg6xfQiu-SHJuUaftTC+vShm5+ZyqV7GQZgw@mail.gmail.com>

O> For example, this is what I've got currently:
> 
> /* Detect and warn about potential overlaps. */
> void *memcpy(void *dest, const void *src, size_t n)
> {
>         if (dest > src && dest - src < n)
>                 warn("Potentially unsafe overlapping memcpy detected!");
>         return __memcpy(dest, src, n);
> }
> 
> Does that seem okay? If so, I'll send the patch...

Probably useful for debug, but instead of relying on __memcpy
happening to handle overlaps - which isn't portable you could instead
debug all platforms by doing

	if (...) {
		warn(...)
		memmove()
	} else
		__memcpy


Alan

  reply	other threads:[~2016-04-28 16:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 21:46 Kees Cook
2016-04-28  9:02 ` Ingo Molnar
2016-04-28  9:04 ` Ingo Molnar
2016-04-28  9:18   ` Kees Cook
2016-04-28  9:37     ` Ingo Molnar
2016-04-28 16:01       ` Kees Cook
2016-04-28 16:31       ` Kees Cook
2016-04-28 16:47         ` One Thousand Gnomes [this message]
2016-04-28 16:49           ` Kees Cook
2016-04-28 17:45             ` Ingo Molnar
2016-04-28 10:29 ` [tip:x86/boot] " tip-bot for Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428174731.042b7394@lxorguk.ukuu.org.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=bhe@redhat.com \
    --cc=bp@suse.de \
    --cc=dvyukov@google.com \
    --cc=hjl.tools@gmail.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®