From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752945AbcD2Cus (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Apr 2016 22:50:48 -0400
Received: from mail-pa0-f67.google.com ([209.85.220.67]:36022 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752756AbcD2Cur (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Apr 2016 22:50:47 -0400
Date: Fri, 29 Apr 2016 20:50:38 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: drzix <korea.drzix@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/2] perf report: Find lib path correctly for gtk option
Message-ID: <20160429115038.GB3094@danjae.aot.lge.com>
References: <1461848401-32125-1-git-send-email-korea.drzix@gmail.com>
 <20160428140751.GA17161@krava>
 <CAMD-KS9fwiwvuOoO0VzFFJTOKSq3uV7dtFHfAZz6ADH3zJ7CvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAMD-KS9fwiwvuOoO0VzFFJTOKSq3uV7dtFHfAZz6ADH3zJ7CvA@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi drzix,

On Thu, Apr 28, 2016 at 11:35:09PM +0900, drzix wrote:
> Hi,
> 
> $ ./perf report --gtk
> GTK browser requested but could not find libperf-gtk.so
> 
> 
> When I print buf in setup_gtk_brower() in ui/setup.c:
> 
> $ ./perf report --gtk
> /libperf-gtk.so
> GTK browser requested but could not find libperf-gtk.so
> 
> Besides, LIBDIR path is just ""

AFAIK this fallback code is only needed if perf was not installed in
the standard directory (and system has no perf package installed
also).  Anyway I think it's better to add a debug message when loading
is failed (preferably with dlerror() or so).

In addition, I think the loading order should be reversed.  It
currently tries to load libperf-gtk.so in the system directory and
then LIBDIR/libperf-gtk.so.  But it'd be better to try LIBDIR first
and then falls back to system directory IMHO.

> 
> Does it mean that LIBDIR path could not take the prefix contained to
> Makefile.perf?

No, LIBDIR used to libdir_SQ.

Thanks,
Namhyung


> 
> 2016-04-28 23:07 GMT+09:00 Jiri Olsa <jolsa@redhat.com>:
> > On Thu, Apr 28, 2016 at 10:00:00PM +0900, Kyeongmin Cho wrote:
> >> When "perf report --gtk", it cannot find libperf-gtk.so.
> >> This patch apply correct path of LIBDIR to setup_gtk_browser().
> >
> > hi,
> > could you please add to changelog some more info
> > about why the case change is actualy needed?
> >
> > thanks,
> > jirka
> >
> >>
> >> Signed-off-by: Kyeongmin Cho <korea.drzix@gmail.com>
> >> ---
> >>  tools/perf/config/Makefile | 2 +-
> >>  tools/perf/ui/Build        | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> >> index f7d7f5a..d96b185 100644
> >> --- a/tools/perf/config/Makefile
> >> +++ b/tools/perf/config/Makefile
> >> @@ -794,7 +794,7 @@ $(call detected_var,prefix_SQ)
> >>  $(call detected_var,perfexecdir_SQ)
> >>  $(call detected_var,tipdir_SQ)
> >>  $(call detected_var,srcdir_SQ)
> >> -$(call detected_var,LIBDIR)
> >> +$(call detected_var,libdir)
> >>  $(call detected_var,GTK_CFLAGS)
> >>  $(call detected_var,PERL_EMBED_CCOPTS)
> >>  $(call detected_var,PYTHON_EMBED_CCOPTS)
> >> diff --git a/tools/perf/ui/Build b/tools/perf/ui/Build
> >> index 0a73538..cd3f92f0 100644
> >> --- a/tools/perf/ui/Build
> >> +++ b/tools/perf/ui/Build
> >> @@ -5,7 +5,7 @@ libperf-y += util.o
> >>  libperf-y += hist.o
> >>  libperf-y += stdio/hist.o
> >>
> >> -CFLAGS_setup.o += -DLIBDIR="BUILD_STR($(LIBDIR))"
> >> +CFLAGS_setup.o += -DLIBDIR="BUILD_STR($(libdir))"
> >>
> >>  libperf-$(CONFIG_SLANG) += browser.o
> >>  libperf-$(CONFIG_SLANG) += browsers/
> >> --
> >> 2.5.5
> >>
> 
> 
> 
> -- 
> Thanks,
> Dr.Zix
> " http://cin.fail "