From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: use devm_add_action_or_reset
Date: Sat, 30 Apr 2016 17:14:41 +0100 [thread overview]
Message-ID: <20160430161441.GA24054@sudip-laptop> (raw)
In-Reply-To: <571F418C.1090005@gmail.com>
On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
>
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
>
> if (rc)
> return rc;
>
> return 0;
>
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.
ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.
regards
sudip
prev parent reply other threads:[~2016-04-30 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:51 Sudip Mukherjee
2016-04-26 10:23 ` Eli Billauer
2016-04-30 16:14 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160430161441.GA24054@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®