From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbcD3U4n (ORCPT ); Sat, 30 Apr 2016 16:56:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55278 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbcD3U4l (ORCPT ); Sat, 30 Apr 2016 16:56:41 -0400 Date: Sat, 30 Apr 2016 13:56:40 -0700 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org, "Maciej S. Szmigiero" Subject: Re: [PATCH] parport: parport_pc: PCI SIO access should also depend on SIO option Message-ID: <20160430205640.GA9218@kroah.com> References: <1461137991-3834-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461137991-3834-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 01:09:51PM +0530, Sudip Mukherjee wrote: > From: "Maciej S. Szmigiero" > > CONFIG_PARPORT_PC_SUPERIO toggles Super IO chip support in parport_pc > code, however only code accessing SIO chip via ISA (or LPC) bus was > conditional on it. > > This patch makes SIO chip accesses via PCI bus also dependent on this > config option. > > It should be noted that Super IO support in parport_pc is needed only when > firmware has failed to make parallel port available either via PNP or > on standard I/O ranges and user has one of a few supported SIOs. > > Signed-off-by: Maciej S. Szmigiero > --- > > Hi Greg, > This patch is not tested on any superio chip based hardware. (I also > don't have one). > http://www.spinics.net/lists/kernel/msg2227051.html > > I know you dislike adding #ifdef so its upto you. It's really a messy patch, surely there is a better solution.