From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbcEAHrd (ORCPT ); Sun, 1 May 2016 03:47:33 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35361 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcEAHrc (ORCPT ); Sun, 1 May 2016 03:47:32 -0400 Date: Sun, 1 May 2016 08:45:12 +0100 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org, "Maciej S. Szmigiero" Subject: Re: [PATCH] parport: parport_pc: PCI SIO access should also depend on SIO option Message-ID: <20160501074512.GA27386@sudip-laptop> References: <1461137991-3834-1-git-send-email-sudipm.mukherjee@gmail.com> <20160430205640.GA9218@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160430205640.GA9218@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 30, 2016 at 01:56:40PM -0700, Greg Kroah-Hartman wrote: > On Wed, Apr 20, 2016 at 01:09:51PM +0530, Sudip Mukherjee wrote: > > From: "Maciej S. Szmigiero" > > > > CONFIG_PARPORT_PC_SUPERIO toggles Super IO chip support in parport_pc > > code, however only code accessing SIO chip via ISA (or LPC) bus was > > conditional on it. > > > > This patch makes SIO chip accesses via PCI bus also dependent on this > > config option. > > > > It should be noted that Super IO support in parport_pc is needed only when > > firmware has failed to make parallel port available either via PNP or > > on standard I/O ranges and user has one of a few supported SIOs. > > > > Signed-off-by: Maciej S. Szmigiero > > --- > > > > Hi Greg, > > This patch is not tested on any superio chip based hardware. (I also > > don't have one). > > http://www.spinics.net/lists/kernel/msg2227051.html > > > > I know you dislike adding #ifdef so its upto you. > > It's really a messy patch, surely there is a better solution. yes, might be. But without hardware, should i dare? regards sudip