From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbcEAXSA (ORCPT ); Sun, 1 May 2016 19:18:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:62481 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbcEAXRt (ORCPT ); Sun, 1 May 2016 19:17:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,564,1455004800"; d="scan'208";a="966616880" Date: Mon, 2 May 2016 01:17:45 +0200 From: Samuel Ortiz To: Michael Thalmeier Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , linux-kernel@vger.kernel.org, linux-nfc@ml01.01.org, michael@thalmeier.at Subject: Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped Message-ID: <20160501231745.GD19653@zurbaran.home> References: <1461249839-16962-1-git-send-email-michael.thalmeier@hale.at> <1461249839-16962-7-git-send-email-michael.thalmeier@hale.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461249839-16962-7-git-send-email-michael.thalmeier@hale.at> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Thu, Apr 21, 2016 at 04:43:54PM +0200, Michael Thalmeier wrote: > When a poll ist stopped we need to kill the out_urb request too before > starting a new request. > > Additionally check if cmd is set in pn533_recv_ack befor accessing its struct > members. I understand those 2 (stopping a poll and cmd being NULL) are not completely unrelated, but I'd prefer if we could have separate patches here. As a matter of fact it seems you're trying to handle a potential NULL cmd pointer in several of the subsequent patches and I'd like to see all of those grouped in one patch with an explanation as to why we need to do this (i.e. how come we can have such pointer being NULL). Cheers, Samuel.