From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbcEAXSO (ORCPT ); Sun, 1 May 2016 19:18:14 -0400 Received: from mga04.intel.com ([192.55.52.120]:25564 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbcEAXSI (ORCPT ); Sun, 1 May 2016 19:18:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,564,1455004800"; d="scan'208";a="95347601" Date: Mon, 2 May 2016 01:18:00 +0200 From: Samuel Ortiz To: Michael Thalmeier Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , linux-kernel@vger.kernel.org, linux-nfc@ml01.01.org, michael@thalmeier.at Subject: Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll Message-ID: <20160501231800.GF19653@zurbaran.home> References: <1461249839-16962-1-git-send-email-michael.thalmeier@hale.at> <1461249839-16962-9-git-send-email-michael.thalmeier@hale.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461249839-16962-9-git-send-email-michael.thalmeier@hale.at> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Thu, Apr 21, 2016 at 04:43:56PM +0200, Michael Thalmeier wrote: > @@ -1259,7 +1259,8 @@ static int pn533_rf_complete(struct pn533 *dev, void *arg, > if (IS_ERR(resp)) { > rc = PTR_ERR(resp); > > - nfc_err(dev->dev, "RF setting error %d\n", rc); > + if (rc != -ENOENT) > + nfc_err(dev->dev, "RF setting error %d\n", rc); Why ? > > return rc; > } > @@ -1416,9 +1417,6 @@ static int pn533_poll_complete(struct pn533 *dev, void *arg, > if (IS_ERR(resp)) { > rc = PTR_ERR(resp); > > - nfc_err(dev->dev, "%s Poll complete error %d\n", > - __func__, rc); > - Why are you removing that one ? Cheers, Samuel.