From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753272AbcEBILQ (ORCPT ); Mon, 2 May 2016 04:11:16 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35680 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbcEBILK (ORCPT ); Mon, 2 May 2016 04:11:10 -0400 Date: Mon, 2 May 2016 13:41:06 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: Viresh Kumar , "Rafael J. Wysocki" , Nishanth Menon , Stephen Boyd , Len Brown , Pavel Machek , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / OPP: pass cpumask by reference Message-ID: <20160502081106.GG2855@vireshk-i7> References: <1462016049-1976580-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462016049-1976580-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-04-16, 13:33, Arnd Bergmann wrote: > The new use of dev_pm_opp_set_sharing_cpus resulted in a harmless compiler > warning with CONFIG_CPUMASK_OFFSTACK=y: > > drivers/cpufreq/mvebu-cpufreq.c: In function 'armada_xp_pmsu_cpufreq_init': > include/linux/cpumask.h:550:25: error: passing argument 2 of 'dev_pm_opp_set_sharing_cpus' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > > The problem here is that cpumask_var_t gets passed by reference, but > by declaring a 'const cpumask_var_t' argument, only the pointer is > constant, not the actual mask. This is harmless because the function > does not actually modify the mask. > > This patch changes the function prototypes for all of the related functions > to pass a 'struct cpumask *' instead of 'cpumask_var_t', matching what > most other such functions do in the kernel. This lets us mark all the > other similar functions as taking a 'const' mask where possible, > and it avoids the warning without any change in object code. > > Signed-off-by: Arnd Bergmann > Fixes: 947bd567f7a5 ("mvebu: Use dev_pm_opp_set_sharing_cpus() to mark OPP tables as shared") > --- > drivers/base/power/opp/cpu.c | 10 +++++----- > include/linux/pm_opp.h | 20 ++++++++++---------- > 2 files changed, 15 insertions(+), 15 deletions(-) Acked-by: Viresh Kumar -- viresh