From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbcEBLAQ (ORCPT ); Mon, 2 May 2016 07:00:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41238 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378AbcEBLAL (ORCPT ); Mon, 2 May 2016 07:00:11 -0400 Date: Mon, 2 May 2016 12:00:01 +0100 From: Mark Brown To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160502110001.GF6292@sirena.org.uk> References: <1461911198-2895-1-git-send-email-baolu.lu@linux.intel.com> <1461911198-2895-2-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uTRFFR9qmiCqR05s" Content-Disposition: inline In-Reply-To: <1461911198-2895-2-git-send-email-baolu.lu@linux.intel.com> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uTRFFR9qmiCqR05s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); > + if (IS_ERR(gpiod)) > + return PTR_ERR(gpiod); This is clearly an inappropriate name for the signal in generic code, it's specific to your use case. --uTRFFR9qmiCqR05s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXJzMwAAoJECTWi3JdVIfQ0r8H/juQcUS7/Hek5gKDUPNGyo0J 2yl+zdmLZjJQD8e9wT8MAF+SDGwBUs//Ikwsew3ndFqArIG7wh9XQ46wBpCy1Ggu 9LBydsR/0Gln9DivGbVXwSYmt/yBGMfMuLQfJx12hzlbQ9juvxTmWyc09Oji9OuU z7I86rSnbPK+NcrsxBIHkwhMvTkGtFpdw9BTxV9SMPDviT/F9+mW5KZyYD4fpbAs 8iGJtYN/TTI5xC2dIbnbK1BsoeyqmXmc9uqAgE77AZ4yGeb1lKXE8S3VCK3rBOxu LREpcOhbXo0Q3X4c3Zw+tnzZ/fieq3PzFRuRKJDxjLa6AY+qLgATjdyjul8pByI= =c/lG -----END PGP SIGNATURE----- --uTRFFR9qmiCqR05s--