From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbcEBOAx (ORCPT ); Mon, 2 May 2016 10:00:53 -0400 Received: from mail.kernel.org ([198.145.29.136]:53180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753935AbcEBOAm (ORCPT ); Mon, 2 May 2016 10:00:42 -0400 Date: Mon, 2 May 2016 09:00:32 -0500 From: Rob Herring To: Arnd Bergmann Cc: Frank Rowand , Grant Likely , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Maxime Ripard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] of: include errno.h in of_graph.h Message-ID: <20160502140032.GA12801@rob-hp-laptop> References: <1462186769-2205767-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462186769-2205767-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 12:59:19PM +0200, Arnd Bergmann wrote: > When CONFIG_OF is disabled, we have to include linux/errno.h before > including of_graph.h, or get build errors like in the newly added > sun4i drm driver: > > In file included from ../drivers/gpu/drm/sun4i/sun4i_drv.c:14:0: > include/linux/of_graph.h: In function 'of_graph_parse_endpoint': > include/linux/of_graph.h:58:10: error: 'ENOSYS' undeclared (first use in this function) > > A better solution is to ensure that the header can be included > by itself, so let's include linux/errno.h here to fix the error > we just got, and any similar future error. > > Signed-off-by: Arnd Bergmann > Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") > --- > include/linux/of_graph.h | 1 + > 1 file changed, 1 insertion(+) Applied. Rob