From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755229AbcEBVxX (ORCPT ); Mon, 2 May 2016 17:53:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56509 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754390AbcEBVxV (ORCPT ); Mon, 2 May 2016 17:53:21 -0400 Date: Mon, 2 May 2016 14:53:20 -0700 From: Andrew Morton To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, Javier Martinez Canillas , Brian Norris , Sjoerd Simons , Rusty Russell , Greg Kroah-Hartman , kernel@pengutronix.de Subject: Re: [PATCH] modpost: fix module autoloading for OF devices with generic compatible property Message-Id: <20160502145320.f4529b37b32c9ec0a9fc96e1@linux-foundation.org> In-Reply-To: <1462203339-15340-1-git-send-email-p.zabel@pengutronix.de> References: <1462203339-15340-1-git-send-email-p.zabel@pengutronix.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 May 2016 17:35:39 +0200 Philipp Zabel wrote: > Since the wildcard at the end of OF module aliases is gone, autoloading > of modules that don't match a device's last (most generic) compatible value > fails. > > For example the CODA960 VPU on i.MX6Q has the SoC specific compatible > "fsl,imx6q-vpu" and the generic compatible "cnm,coda960". Since the driver > currently only works with knowledge about the SoC specific integration, > it doesn't list "cnm,cod960" in the module device table. > This results in the device compatible > "of:NvpuTCfsl,imx6q-vpuCcnm,coda960" not matching the module alias > "of:N*T*Cfsl,imx6q-vpu" anymore, whereas before commit 2f632369ab79 > ("modpost: don't add a trailing wildcard for OF module aliases") it > matched the module alias "of:N*T*Cfsl,imx6q-vpu*". > > This patch adds two module aliases for each compatible, one without the > wildcard and one with "C*" appended. > > $ modinfo coda | grep imx6q > alias: of:N*T*Cfsl,imx6q-vpuC* > alias: of:N*T*Cfsl,imx6q-vpu I added this: Cc: [4.5+]