From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086AbcEBPEZ (ORCPT ); Mon, 2 May 2016 11:04:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36284 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbcEBPEQ (ORCPT ); Mon, 2 May 2016 11:04:16 -0400 Date: Mon, 2 May 2016 17:04:13 +0200 From: Daniel Vetter To: Rob Clark Cc: Gustavo Padovan , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , David Airlie , Daniel Vetter , Ander Conselvan de Oliveira , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Carlos Palminha , Hai Li , Maarten Lankhorst , Archit Taneja , Daniel Stone , jilai wang , open list Subject: Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank_event() Message-ID: <20160502150413.GS14148@phenom.ffwll.local> Mail-Followup-To: Rob Clark , Gustavo Padovan , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , David Airlie , Ander Conselvan de Oliveira , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Carlos Palminha , Hai Li , Maarten Lankhorst , Archit Taneja , Daniel Stone , jilai wang , open list References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> <1460656118-16766-5-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2016 at 04:51:06PM -0400, Rob Clark wrote: > On Thu, Apr 14, 2016 at 1:48 PM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Replace the legacy drm_send_vblank_event() with the new helper function. > > > > Signed-off-by: Gustavo Padovan > > thanks, shall I take this via msm-next for 4.7, I assume? Looks like > no dependency on drm-core patches that haven't already landed? > > Reviewed-by: Rob Clark Applied to drm-misc, thanks. -Daniel > > > --- > > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 2 +- > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > index e233acf..3a48889 100644 > > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > @@ -121,7 +121,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > > if (!file || (event->base.file_priv == file)) { > > mdp4_crtc->event = NULL; > > DBG("%s: send event: %p", mdp4_crtc->name, event); > > - drm_send_vblank_event(dev, mdp4_crtc->id, event); > > + drm_crtc_send_vblank_event(crtc, event); > > } > > } > > spin_unlock_irqrestore(&dev->event_lock, flags); > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > index 9673b95..ce779d9 100644 > > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > @@ -149,7 +149,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > > if (!file || (event->base.file_priv == file)) { > > mdp5_crtc->event = NULL; > > DBG("%s: send event: %p", mdp5_crtc->name, event); > > - drm_send_vblank_event(dev, mdp5_crtc->id, event); > > + drm_crtc_send_vblank_event(crtc, event); > > } > > } > > spin_unlock_irqrestore(&dev->event_lock, flags); > > -- > > 2.5.5 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch