From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933818AbcECQGA (ORCPT ); Tue, 3 May 2016 12:06:00 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47168 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932904AbcECQF7 (ORCPT ); Tue, 3 May 2016 12:05:59 -0400 Date: Tue, 03 May 2016 12:05:56 -0400 (EDT) Message-Id: <20160503.120556.1317913903199470646.davem@davemloft.net> To: lars.ellenberg@linbit.com Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit() From: David Miller In-Reply-To: <20160503100644.GE16459@soda.linbit> References: <57286F49.8050107@6wind.com> <1462268358-19044-1-git-send-email-nicolas.dichtel@6wind.com> <20160503100644.GE16459@soda.linbit> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 May 2016 09:05:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Ellenberg Date: Tue, 3 May 2016 12:06:44 +0200 > Please just NOT use an additional "field", > but always use 0 to pad. You can't, it doesn't work. We are adding a new field to every netlink protocol family that has this alignment problem.