From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281AbcECHPJ (ORCPT ); Tue, 3 May 2016 03:15:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:51767 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbcECHPI (ORCPT ); Tue, 3 May 2016 03:15:08 -0400 Date: Tue, 3 May 2016 09:15:04 +0200 From: Johannes Thumshirn To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfit: fix translation of command status results Message-ID: <20160503071503.GH25505@c203.arch.suse.de> References: <146220634174.8521.14748358560688740425.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <146220634174.8521.14748358560688740425.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 09:25:41AM -0700, Dan Williams wrote: > When transportation of the command completes successfully, it indicates > that the 'status' result is valid. Fix the missed checking and > translation of the status field at the end of acpi_nfit_ctl(). > Otherwise, we fail to handle reported errors and assume commands > complete successfully. > > Reported-by: Linda Knippers > Signed-off-by: Dan Williams Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850