From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755730AbcECJAa (ORCPT ); Tue, 3 May 2016 05:00:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:35659 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755667AbcECJA1 (ORCPT ); Tue, 3 May 2016 05:00:27 -0400 Date: Tue, 3 May 2016 11:00:21 +0200 From: Jan Kara To: Christoph Hellwig Cc: Toshi Kani , dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Message-ID: <20160503090021.GC12748@quack2.suse.cz> References: <1462214578-27122-1-git-send-email-toshi.kani@hpe.com> <1462214578-27122-2-git-send-email-toshi.kani@hpe.com> <20160503084410.GB31363@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160503084410.GB31363@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-05-16 01:44:10, Christoph Hellwig wrote: > Please come up with a version that doesn't require tons of boilerplate > code in every file system. Well, I was thinking about some helper as well but we could save ~4 lines with that and that didn't seem significant to me. Most of the lines is actually reporting appropriate mount error in dmesg and that is fs-dependent so it needs to stay in the filesystem... So what do you have in mind? Honza -- Jan Kara SUSE Labs, CR