From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932958AbcECLtx (ORCPT ); Tue, 3 May 2016 07:49:53 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44434 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932498AbcECLtv (ORCPT ); Tue, 3 May 2016 07:49:51 -0400 Date: Tue, 3 May 2016 12:49:35 +0100 From: Mark Brown To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160503114935.GO6292@sirena.org.uk> References: <1461911198-2895-1-git-send-email-baolu.lu@linux.intel.com> <1461911198-2895-2-git-send-email-baolu.lu@linux.intel.com> <20160502110001.GF6292@sirena.org.uk> <5728025E.9040902@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gh4H09KImyIEQ1se" Content-Disposition: inline In-Reply-To: <5728025E.9040902@linux.intel.com> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gh4H09KImyIEQ1se Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: > On 05/02/2016 07:00 PM, Mark Brown wrote: > > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); > >> + if (IS_ERR(gpiod)) > >> + return PTR_ERR(gpiod); > > This is clearly an inappropriate name for the signal in generic code, > > it's specific to your use case. > I will change the gpio name to "gpio". Is that okay? Yes, that looks good (and lines up with DT so hopefully the code can be shared). --gh4H09KImyIEQ1se Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXKJBOAAoJECTWi3JdVIfQ6MAH/jkMtCB2X7mg9r2jdwXIvKzv 0orIRRloCb3K+vDG/lS41aesxnPv5xM9u0UCUAJpx7sVb5WwEgaeMFqwsuy6hdQ0 FMSf5VLHRIGSa0opNH0jBB1+xpoHU+CnMgpSJinbh7xY42E5JUPk8Cka/f/oyYea If6K4YSqAEcGfLmwSs8/H1643bdpsSDD+Ayqy3+fStM6+l65B9+483DPpkyeRGo5 jAR7EVxjrEQqW9t5SyfhEAiF++JrFprbPo7FCSjE3X/lAxYoHl5pC3SpwUarEmS8 Mpq7/OlUX//FZYAEL/pDnr70okogXhAJnx24o0wHWrpqsZXwpaXoueIhYDO1uM0= =Ki2u -----END PGP SIGNATURE----- --gh4H09KImyIEQ1se--