From: Thierry Reding <thierry.reding@gmail.com>
To: Shardar Mohammed <smohammed@nvidia.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: tegra: crash fix observed during dma client(UART) stress testing
Date: Tue, 3 May 2016 17:17:40 +0200 [thread overview]
Message-ID: <20160503151740.GB19539@ulmo.ba.sec> (raw)
In-Reply-To: <ec7e4483c2d74e36ade15e26684a6ee8@bgmail102.nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
On Tue, May 03, 2016 at 02:44:49PM +0000, Shardar Mohammed wrote:
> Thanks for review. Please find my comments inline.
>
> > On 03/05/16 13:14, Shardar Shariff Md wrote:
> > > During DMA client(UART) stress testing, observed below crash:
> > >
> > > [ 167.041591] Unable to handle kernel paging request at virtual
> > > address 00100108 [ 167.048818] pgd = ffffffc0de7ee000 [ 167.052222]
> > > [00100108] *pgd=0000000000000000 [ 167.056513] Internal error: Oops:
> > > 96000045 [#1] PREEMPT SMP [ 167.084048] Modules linked in:
> > > [ 167.087126] CPU: 0 PID: 1786 Comm: uarttest Tainted: G W 3.10.33-
> > gb76f6f9 #5
> > > [ 167.095040] task: ffffffc0a5ba6ac0 ti: ffffffc094380000 task.ti:
> > > ffffffc094380000 [ 167.102529] PC is at tegra_dma_tasklet+0x50/0xf4 [
> > > 167.107148] LR is at tegra_dma_tasklet+0xc0/0xf4 [ 167.111767] pc :
> > > [<ffffffc00044acc8>] lr : [<ffffffc00044ad38>] pstate: 800001c5 [
> > > 167.119155] sp : ffffffc094383a60 [ 167.122469] x29: ffffffc094383a60
> > > x28: 0000000000000000
> >
> > This appears to be from quite an old kernel. I assume that this is still valid for
> > the latest mainline?
> [Shardar] Yes.
Please get into the habit of testing your patches against upstream
kernels. Merely testing that it applies is not enough.
All patches that are submitted for mainline inclusion must be *runtime*
tested against a mainline kernel.
Also it would be nice if you could offer steps on how to reproduce, that
way we can extend our testing to make sure we never regress.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-05-03 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 12:14 Shardar Shariff Md
2016-05-03 14:09 ` Jon Hunter
2016-05-03 14:44 ` Shardar Mohammed
2016-05-03 15:17 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503151740.GB19539@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smohammed@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®