From: Clark Williams <williams@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: John Kacur <jkacur@redhat.com>,
RT <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cyclictest: stop any tracing after hitting a breaktrace threshold
Date: Tue, 3 May 2016 15:28:39 -0500 [thread overview]
Message-ID: <20160503152839.4543a973@sluggy.hsv.redhat.com> (raw)
In-Reply-To: <20160503155644.0aa34c34@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2332 bytes --]
On Tue, 3 May 2016 15:56:44 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Tue, 3 May 2016 12:59:53 -0500
> Clark Williams <williams@redhat.com> wrote:
>
> > John,
> >
> > This patch is against the devel/v0.98 branch. It turns off tracing in the tracemark() so that we don't lose information about what was going on when we hit the latency:
> >
> >
> > The current logic of using --tracemark and --notrace works for running
> > cyclictest with trace-cmd, but even if we are not doing any trace
> > manipulation in cyclictest, we still need to stop tracing when we hit a
> > breaktrace threshold (i.e. -b <n>).
>
> Does it solve the problem for you if you revert ba4dd1bf54 and start
> cyclictest with:
>
> # cyclictest [...] -bX
>
> Or with:
>
> # cyclictest [...] -bX --tracemark
>
> Also, how do I reproduce your issue? Are you doing tracing by hand?
I'm running:
trace-cmd start -e all -p function
Then kicking off loads and finally running:
cyclictest --numa -p95 -qmu -b 300 --tracemark --notrace
The intent here is that cyclictest do nothing wrt tracing other than stop it when the breaktrace threshold is set.
> > +
> > + /* write the tracemark message */
> > write(tracemark_fd, tracebuf, len);
> > +
> > + /* now stop any trace */
> > + write(trace_fd, "0\n", 2);
> > }
>
> We do tracing(0) when we hit the latency threshold, so I don't
> think this is necessary.
Tracing didn't seem to stop in my scenario above. I suspect it's the --notrace option, which I used to make absolutely certain we didn't touch any tracing bits.
>
> However, have you checked that writing to tracing_on won't break
> trace-cmd when it exec()ed cyclictest?
>
I haven't run cyclictest as a child of trace-cmd. I'll try that, but my use-case is really in running rteval, which runs cyclictest as a measurement tool. So for tracing I need to to 'trace-cmd start' before running rteval.
The intent is to be able to do something like this:
trace-cmd start -e all -p function
rteval --duration=12h --cyclictest-breaktrace=150
trace-cmd extract
That sets a breaktrace threshold of 150 microseconds so that if we terminate the run early, I'll have an ftrace file I can use narrow down on what's causing latency spikes.
Clark
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-05-03 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 17:59 Clark Williams
2016-05-03 19:56 ` Luiz Capitulino
2016-05-03 20:28 ` Clark Williams [this message]
2016-05-04 13:20 ` Luiz Capitulino
2016-05-04 13:49 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503152839.4543a973@sluggy.hsv.redhat.com \
--to=williams@redhat.com \
--cc=jkacur@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®