From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756862AbcECXGc (ORCPT ); Tue, 3 May 2016 19:06:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33476 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756843AbcECXGb (ORCPT ); Tue, 3 May 2016 19:06:31 -0400 Date: Tue, 3 May 2016 16:06:29 -0700 From: Greg KH To: Kangjie Lu Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, linux-kernel@vger.kernel.org, taesoo@gatech.edu, insu@gatech.edu, csong84@gatech.edu, Kangjie Lu Subject: Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations Message-ID: <20160503230629.GB15078@kroah.com> References: <1462313848-7858-1-git-send-email-kjlu@gatech.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462313848-7858-1-git-send-email-kjlu@gatech.edu> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 06:17:28PM -0400, Kangjie Lu wrote: > "mac" is an array allocated in stack without being initialized, > and will be sent out via "nla_put". The dump_station() is supposed > to initialize the mac address; otherwise, sensitive data in kernel > stack will be leaked. To fix this, initialize it with memset or > fill it with meaningful mac address. "or"? You just set it to zero, why not fix this correctly and put the real address here? thanks, greg k-h