From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbcEDSM6 (ORCPT ); Wed, 4 May 2016 14:12:58 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41157 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596AbcEDSM4 (ORCPT ); Wed, 4 May 2016 14:12:56 -0400 Date: Wed, 04 May 2016 14:12:54 -0400 (EDT) Message-Id: <20160504.141254.2216695965556907500.davem@davemloft.net> To: arnd@arndb.de Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, tom@herbertland.com, hakke_007@gmx.de, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gre6: add Kconfig dependency for NET_IPGRE_DEMUX From: David Miller In-Reply-To: <1462288817-721172-1-git-send-email-arnd@arndb.de> References: <1462288817-721172-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 May 2016 11:12:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 3 May 2016 17:19:57 +0200 > The ipv6 gre implementation was cleaned up to share more code > with the ipv4 version, but it can be enabled even when NET_IPGRE_DEMUX > is disabled, resulting in a link error: > > net/built-in.o: In function `gre_rcv': > :(.text+0x17f5d0): undefined reference to `gre_parse_header' > ERROR: "gre_parse_header" [net/ipv6/ip6_gre.ko] undefined! > > This adds a Kconfig dependency to prevent that now invalid > configuration. > > Signed-off-by: Arnd Bergmann > Fixes: 308edfdf1563 ("gre6: Cleanup GREv6 receive path, call common GRE functions") Applied, thanks.