From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934503AbcEDC0N (ORCPT ); Tue, 3 May 2016 22:26:13 -0400 Received: from audible.transient.net ([24.143.126.66]:36060 "HELO audible.transient.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932613AbcEDC0K (ORCPT ); Tue, 3 May 2016 22:26:10 -0400 Date: Wed, 4 May 2016 02:26:09 +0000 From: Jamie Heilman To: David Howells Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tadeusz.struk@intel.com Subject: Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2) Message-ID: <20160504022608.GF20775@cucamonga.audible.transient.net> Mail-Followup-To: David Howells , Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tadeusz.struk@intel.com References: <20160503172536.GC20775@cucamonga.audible.transient.net> <20160430083248.GA20775@cucamonga.audible.transient.net> <26795.1462266613@warthog.procyon.org.uk> <11323.1462307740@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11323.1462307740@warthog.procyon.org.uk> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > > > > > Problem loading in-kernel X.509 certificate (-2) > > > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > > That suggests missing crypto of some sort. > > > > > > The attached patch enables some debugging in some relevant files if you can > > > try applying it to your kernel. > > > > Alrighty, presumably relevant bits: > > > > X.509: Cert Issuer: Build time autogenerated kernel key > > X.509: Cert Subject: Build time autogenerated kernel key > > X.509: Cert Key Algo: rsa > > X.509: Cert Valid period: 1461826791-4615426791 > > X.509: Cert Signature: rsa + sha512 > > X.509: ==>x509_check_signature() > > X.509: ==>x509_get_sig_params() > > X.509: <==x509_get_sig_params() = 0 > > PKEY: ==>public_key_verify_signature() > > X.509: Cert Verification: -2 > > Hmmm... Okay, the only ways out of public_key_verify_signature() without > printing a leaving message are for snprintf() to overrun (which would return > error -22) or for crypto_alloc_akcipher() to have failed; everything else must > go through the kleave() at the pr_devel() at the bottom of the function. > > Can you stick: > > pr_devel("ALGO: %s\n", alg_name); > > immediately before this line: > > tfm = crypto_alloc_akcipher(alg_name, 0, 0); > > and try it again? PKEY: ALGO: pkcs1pad(rsa,sha512) -- Jamie Heilman http://audible.transient.net/~jamie/